Skip to content

Fix crash in error tracking #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2023
Merged

Fix crash in error tracking #1248

merged 2 commits into from
Sep 7, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Sep 7, 2023 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Remove unnecessary TODO() which causes a crash.

Motivation and context

Fix crash when calling DefaultAnalyticsService.trackError().

Note that this crash does not currently surface as no components are calling trackError() however the Rich Text Editor will do.

Screenshots / GIFs

N/A

Tests

N/A

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner September 7, 2023 11:21
@jonnyandrew jonnyandrew requested review from bmarty and removed request for a team September 7, 2023 11:21
@jonnyandrew jonnyandrew enabled auto-merge (squash) September 7, 2023 11:27
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/J4LgiL

@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (7a4a8f2) 57.71% compared to head (1f897cd) 57.71%.
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1248   +/-   ##
========================================
  Coverage    57.71%   57.71%           
========================================
  Files         1078     1078           
  Lines        28038    28038           
  Branches      5777     5777           
========================================
  Hits         16181    16181           
  Misses        9330     9330           
  Partials      2527     2527
Files Changed Coverage Δ
...yticsproviders/posthog/PosthogAnalyticsProvider.kt 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmarty
bmarty approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but I would not include a entry for the changelog since the crash could not occur.

@jonnyandrew jonnyandrew merged commit c44b7eb into develop Sep 7, 2023
@jonnyandrew jonnyandrew deleted the jonny/fix-analytics-crash branch September 7, 2023 13:05
@bmarty
Copy link
Member

bmarty commented Sep 7, 2023

(auto-merge... That's alright, I will remove the entry when doing the release (if I do not forget))

@jonnyandrew jonnyandrew mentioned this pull request Sep 7, 2023
Merged
14 tasks
@jonnyandrew
Copy link
Contributor Author

Sorry about that - I've opened a PR to remove #1249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonnyandrew @bmarty